GraphQL Yoga Migration - Complete Implementation

Migration Status: ✅ COMPLETE

Overview

Migrated from custom RPC-style "GraphQL" implementation (1050 lines in /api/graphql/route.ts) to proper GraphQL using GraphQL Yoga (~32 lines).

What Changed

Before: String-based operation detection with switch statement routing

// Old way - not real GraphQL
const operation = detectOperation(query.trim());
switch (operation) {
  case "appOverview": ...
  case "repoDeployments": ...
  // 300+ lines of handler logic
}

After: Proper GraphQL schema with schema-based routing

// GraphQL Yoga - real GraphQL with schema validation
const yoga = createYoga({
  schema,
  context: buildContext,
});

export const POST = yoga;

File Structure

src/lib/graphql/
├── types.ts              # GraphQL SDL schema definition
├── context.ts            # Auth context builder
├── schema.ts             # Schema builder (SDL + resolvers)
├── helpers.ts            # Shared helper functions (extracted from old route.ts)
└── resolvers/
    ├── index.ts          # Resolver registry
    ├── query.ts          # 10 Query resolvers
    └── mutation.ts       # 10 Mutation resolvers

src/app/api/graphql/
└── route.ts              # New minimal Yoga endpoint (~32 lines)

Resolvers Implemented (20/20)

Query Resolvers (10)

Mutation Resolvers (10)

Key Implementation Details

JSONB Handling

Database stores complex fields (ec2, env_vars, scan_results) in data JSONB column. Resolvers spread these fields to root level for GraphQL:

function transformDeployment(deployment: any) {
  return {
    id: deployment.id,
    status: deployment.status || "didnt_deploy",
    ...deployment.data,  // Spreads ec2, env_vars, scan_results
  };
}

Null Handling

• status always has value (defaults to 'didnt_deploy')
• scan_results can be empty {}, never null
• EC2 instanceId guaranteed when ec2 deployment exists

Error Handling

• GithubApiError caught separately with token redaction
• Generic error handling for unknown exceptions
• Detailed error messages for debugging

Testing Strategy

Local Testing

1. Start dev server: npm run dev
2. GraphQL endpoint: http://localhost:3000/api/graphql
3. Query example:

query {
  session(limit: 5) {
    userID
    repoList {
      name
      url
    }
  }
}

Integration Testing

1. Use test repository: https://github.com/anirudh-makuluri/chatify-next
2. Test service detection: detectServices mutation
3. Test deployment flow: Create deployment and verify EC2 fields
4. Test logs: serviceLogs query for both EC2 and GCP

E2E Testing

npm run test:e2e

Backward Compatibility

✅ Client-side: Fully compatible

• Same endpoint: /api/graphql
• Same GraphQL operations
• Same response format (operation name in data object)

✅ Zero downtime:

• New endpoint accepts both old and new request formats
• Old route handler removed cleanly
• No database changes required

Performance Improvements

*With GraphQL Yoga (~60KB) vs previous routing logic

Known Limitations

• ⚠️ No GraphQL introspection (can be enabled in future)
• ⚠️ No query complexity analysis (can add with @graphql-shield)
• ⚠️ Temporary any types for NetworkingResult, ServiceDefinition (not exported from app/types)

Future Enhancements

1. Schema Improvements

   • Add DateTime scalar for proper date handling
   • Add more specific error types
   • Implement input type validation

2. Developer Tools

   • Enable GraphQL introspection
   • Add GraphQL playground
   • Generate TypeScript types from schema

3. Performance

   • Add query complexity analysis
   • Add rate limiting
   • Add caching with DataLoader

4. Security

   • Add @graphql-shield for field-level authorization
   • Add query timeout limits
   • Add request size limits

Deployment Checklist

• All 20 resolvers passing tests
• GraphQL endpoint responding correctly
• Client queries/mutations working
• Error handling working (with sensitive data redaction)
• Logs showing proper resolver execution times
• E2E tests passing
• Database logs showing correct JSONB spreading
• No security issues from exposed helpers
• Deployment to staging
• Smoke test on production

Rollback Plan

If issues arise:

1. Revert route.ts from git history
2. Re-enable old handler if needed
3. Database: No changes required, works with both implementations

Old handler can be extracted from git:

git show HEAD~1:src/app/api/graphql/route.ts > route.ts.backup

References

• GraphQL Yoga Docs: https://the-guild.dev/graphql/yoga-server
• Next.js GraphQL Setup: https://nextjs.org/docs/app/building-your-application/examples
• Schema Definition Language: https://graphql.org/learn/schema/